Skip to content
This repository has been archived by the owner on May 23, 2022. It is now read-only.

Add the ability for a Drop to have an action. #30

Merged
merged 1 commit into from Feb 11, 2016

Conversation

nickcharlton
Copy link
Contributor

This adds the ability for a Drop to execute a closure when tapped. In addition
to the action completion block, it also has a userInfo dictionary which can
allow a user to pass along data to work with when the closure executes, such as
when using a Drop to respond to a Push Notification.

This adds the ability for a Drop to execute a closure when tapped. In addition
to the action completion block, it also has a `userInfo` dictionary which can
allow a user to pass along data to work with when the closure executes, such as
when using a Drop to respond to a Push Notification.
@morizotter
Copy link
Owner

Thanks for your pull request! I'll merge it! I have a few that I want to change. I'll let you know the change points later;)

morizotter added a commit that referenced this pull request Feb 11, 2016
Add the ability for a Drop to have an action.
@morizotter morizotter merged commit e3e1c61 into morizotter:master Feb 11, 2016
@morizotter
Copy link
Owner

I Added changes to your pr:) Main reason is for simplicity. Changes are below:

a1ee745

Changes

  • Simpify variables.
  • Remove userInfo because closure captures the passed values.
  • Add typealias to drop action.
  • Use optional chaining for simplicity.

I hope you are pleased with these changes:)

@nickcharlton

@nickcharlton
Copy link
Contributor Author

Wonderful, thank you!

And yes, completely happy with your changes!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants