Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollable suggestions list #148

Closed
pdc opened this issue Apr 14, 2016 · 2 comments
Closed

Scrollable suggestions list #148

pdc opened this issue Apr 14, 2016 · 2 comments

Comments

@pdc
Copy link

pdc commented Apr 14, 2016

My customer would like to have the list of suggestions show a scrollbar rather than have the suggestions container extend beyond the bottom of the viewpoint. It is possible to make something that looks the part by setting max-height and overflow-y properties on the suggestions-container element. There are two main problems

  • selecting a suggestion using the arrow keys does not scroll the list to show the focussed suggestion;
  • clicking on the scrollbar collapses the suggestions list on IE.

Is there an easy way to achieve this? Or do I need to dive in to modifying the Autowhatever component?

@cellog
Copy link

cellog commented Apr 15, 2016

this seems related to #133

The problem is that when you interact with the suggestions list, it removes focus from the input, which closes the suggestions list. I think the blur() needs to be a bit more sophisticated. It should close the list ONLY when a user interacts with an element outside the entire component, not just when the input is blurred

@moroshko moroshko changed the title Feature request: Scrollable suggestions list Scrollable suggestions list Apr 21, 2016
@moroshko
Copy link
Owner

moroshko commented May 7, 2016

I believe that this and this will address this issue, so closing this one.

@moroshko moroshko closed this as completed May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants