Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Support of parent references in XPath #98

Open
dachafra opened this issue Nov 25, 2022 · 1 comment
Open

ENH: Support of parent references in XPath #98

dachafra opened this issue Nov 25, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@dachafra
Copy link
Contributor

What Happens?

When you have an XPath expression with references to the parent node, it does not generate data. The problem is in the use of findall function in this line as it only allows access to the children in the tree, see the documentation

To Reproduce

Data and Mapping are attached, together with the desirable output generated using the RMLMapper v6.1.2
data_mapping_output_xpath.zip

Environment (please complete the following information):

  • OS: macOS Ventura 13.0.1
  • Python version: 3.9.6
  • Morph-KGC version: 2.2.0
@dachafra dachafra added the bug Something isn't working label Nov 25, 2022
@arenas-guerrero-julian
Copy link
Member

arenas-guerrero-julian commented Nov 25, 2022 •
edited

This is a feature of the RMLMapper (as @jatoledo and @ocorcho know well) that is not enforced by the RML specification. The same happens for JSONPath.

@arenas-guerrero-julian arenas-guerrero-julian removed their assignment Nov 25, 2022
@arenas-guerrero-julian arenas-guerrero-julian added enhancement New feature or request and removed bug Something isn't working labels Nov 25, 2022
@arenas-guerrero-julian arenas-guerrero-julian changed the title BUG: Parent references in XPath do not work ENH: Parent references in XPath do not work Nov 25, 2022
@arenas-guerrero-julian arenas-guerrero-julian changed the title ENH: Parent references in XPath do not work ENH: Support of parent references in XPatH Nov 25, 2022
@arenas-guerrero-julian arenas-guerrero-julian changed the title ENH: Support of parent references in XPatH ENH: Support of parent references in XPath Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dachafra @arenas-guerrero-julian