Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconvenient centering with multiple displays #38

Closed
emulti opened this issue Apr 10, 2020 · 6 comments
Closed

Inconvenient centering with multiple displays #38

emulti opened this issue Apr 10, 2020 · 6 comments
Labels
good first issue Good for newcomers gui gui changes

Comments

@emulti
Copy link

emulti commented Apr 10, 2020

When using nordpy with multiple monitors, the 'centering' code uses the dimensions of the extended desktop rather than (I suggest) 'screen 1', giving an odd position on setups with differently-sized displays.

Expected behavior
nordpy window opens at centre of one of the screens

Actual behaviour
nordpy opens at centre of extended desktop

Desktop (please complete the following information):

  • Arch Linux
  • aur/nordpy 1.3.3-1

Very nice application, a lightweight alternative to the "official" nordvpn binary that doesn't use 200MB of memory.

@emulti emulti changed the title Centering with multiple displays inconvenient Centering/Font scaling with multiple displays inconvenient Apr 10, 2020
@emulti
Copy link
Author

emulti commented Apr 10, 2020

The font scaling behaviour with multiple displays could also be improved.
Gnome/Xorg: Fonts appear very tiny unless only one display connected. Probably because dimensions of extended desktop are used in calculating the font size. If only one display connected the behaviour is perfect.

Gnome/Wayland (+ XWayland)
Multiple displays: Fonts are slightly larger than normal
Single display: normal behaviour.

@morpheusthewhite
Copy link
Owner

The font scaling behaviour with multiple displays could also be improved.
Gnome/Xorg: Fonts appear very tiny unless only one display connected. Probably because dimensions of extended desktop are used in calculating the font size. If only one display connected the behaviour is perfect.

That's strange since the actual size of the font is unchanged in the application, it completely relies on the tkinter library in that sense.

@morpheusthewhite morpheusthewhite added gui gui changes good first issue Good for newcomers labels Apr 10, 2020
@emulti
Copy link
Author

emulti commented Apr 10, 2020

Font size under Wayland is the same with both single/multiple screens. (I was wrong earlier, the dpi is different between the two screens.)

Under Xorg, single screen:
xorg_single screen

Xorg, two screens:
xorg_two screens

Obviously the centering of the window (which uses self.winfo_screenwidth()) is a separate issue

@morpheusthewhite
Copy link
Owner

I created a new issue to reference this last problem

@morpheusthewhite morpheusthewhite changed the title Centering/Font scaling with multiple displays inconvenient Inconvenient centering with multiple displays Apr 11, 2020
@emulti
Copy link
Author

emulti commented Apr 11, 2020

Correct, having solved #40 the issue is confined to the centering on startup only.

@morpheusthewhite
Copy link
Owner

Just installing screeninfo (pip3 install screeninfo) will fix the centering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers gui gui changes
Projects
None yet
Development

No branches or pull requests

2 participants