Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out lines that are not a part of a PR? #51

Open
petethepig opened this issue May 12, 2021 · 2 comments
Open

Filter out lines that are not a part of a PR? #51

petethepig opened this issue May 12, 2021 · 2 comments

Comments

@petethepig
Copy link

petethepig commented May 12, 2021

Cool project!

We've started using revive-action at Pyroscope and one of the issues we've ran into is that github has a limit of 10 annotations max.

This means for most of our PRs it's going to show annotations for lines that were not changed in the PR, and so it's less useful.

It would be cool if revive-action could remove the lines that are not relevant for the current PR, this way getting around this github limitation.

Thanks!

@morphy2k
Copy link
Owner

Hey @petethepig, thank you and sorry for the late reply! The issue got completely lost in my feed.

I will see if I can find a solution for it.
The problem I currently see is that Revive can only check complete files. If there are errors in the changed file that were not caused by the particular commit, they will still be caught.

And also thank you for your support! ❤️

@sdoshidensity
Copy link

@morphy2k Is there any update on this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants