Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor for dataset #2

Closed
morris opened this issue Oct 27, 2020 · 1 comment
Closed

Refactor for dataset #2

morris opened this issue Oct 27, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@morris
Copy link
Owner

morris commented Oct 27, 2020

dataset is well supported and can otherwise be polyfilled, no need to use get/setAttribute for the data attributes.
@morris morris added the good first issue Good for newcomers label Oct 27, 2020
@morris
Copy link
Owner Author

morris commented Oct 29, 2020

#7

@morris morris closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@morris