You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would throw an EngineException (PHP7) for consistency with PHP's own type hinting.
Or, better, I'd use trigger_error() for PHP5 compatibility (which would presumably result in a EngineException in PHP7)
The text was updated successfully, but these errors were encountered:
As an update PHP 7 will have TypeError which does not descend from \Exception but is a sibling class instead. I will need to re-evaluate what I do in this repository for all exceptions because of this.
I would throw an EngineException (PHP7) for consistency with PHP's own type hinting.
Or, better, I'd use trigger_error() for PHP5 compatibility (which would presumably result in a EngineException in PHP7)
The text was updated successfully, but these errors were encountered: