Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Ardent have a TypeException? #29

Open
Wes0617 opened this issue Apr 2, 2015 · 2 comments
Open

Should Ardent have a TypeException? #29

Wes0617 opened this issue Apr 2, 2015 · 2 comments

Comments

@Wes0617
Copy link

Wes0617 commented Apr 2, 2015

I would throw an EngineException (PHP7) for consistency with PHP's own type hinting.
Or, better, I'd use trigger_error() for PHP5 compatibility (which would presumably result in a EngineException in PHP7)

@morrisonlevi
Copy link
Owner

PHP 7 is likely adding a TypeException class. I'll wait to see how that all pans out.

@morrisonlevi
Copy link
Owner

As an update PHP 7 will have TypeError which does not descend from \Exception but is a sibling class instead. I will need to re-evaluate what I do in this repository for all exceptions because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants