Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variance instead of SE #2

Closed
2 tasks done
morrowcj opened this issue Aug 29, 2022 · 5 comments
Closed
2 tasks done

Variance instead of SE #2

morrowcj opened this issue Aug 29, 2022 · 5 comments

Comments

@morrowcj
Copy link
Owner

morrowcj commented Aug 29, 2022

In fitAR, the returned values of SE are, in fact, variances.

  • The code should be something like SE = diag(s2beta)^0.5
  • check if other versions of fitX have this problem.
@Rapsodia86
Copy link

Hi,
any plans to have it updated?

@arives
Copy link
Collaborator

arives commented Nov 14, 2022 via email

@Rapsodia86
Copy link

Hello,
Thanks for the quick answer!
Yes, I have explored the code to find where to apply the correction (or to be aware about the output).
But I appreciate the fact you are going to do this! Thanks!

@morrowcj
Copy link
Owner Author

morrowcj commented Nov 23, 2022

@Rapsodia86 and @arives,

I just wanted to alert you that I've corrected this with PR #4 which has been merged into the live branch, as soon as the build checks finished running. Sorry it took so long to get to this simple fix!

Having addressed the problem, I'm closing this issue now.

@Rapsodia86
Copy link

Thank you for the update and fixing the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants