Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with CIGAR operators X/= #10

Open
pdishuck opened this issue Apr 12, 2019 · 3 comments
Open

Incompatible with CIGAR operators X/= #10

pdishuck opened this issue Apr 12, 2019 · 3 comments

Comments

@pdishuck
Copy link

This tool fails for SAM files using X/= CIGAR operators instead of M, which are coming into more common use. It seems to be a quick fix to look for X and = in any place the current code looks for M, but there may be some side effects I'm not aware of.

@dewyman
Copy link
Member

dewyman commented Apr 15, 2019

Thank you, I will keep that in mind for a future version. The X may pose a slight challenge because there is an internal step that merges the MD tag and CIGAR string information, and that step uses X characters to represent mismatches from reference. But in the meantime, a good solution to allow TranscriptClean to run on these files would be to use regex or perhaps a simple script to convert the X/= in the CIGAR string to M.

@laurenfitch
Copy link

Just wanted to chime in that I hope you do add support for X/= cigar operators in the future! In the meantime, would it be possible to add a note to the readme or the wiki about this requirement?

@dewyman
Copy link
Member

dewyman commented Jun 18, 2019

No problem- a note has been added to the README. I will work on the compatibility issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants