Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findModules() inappropriately passes all kwargs to pickSoftThreshold() and cuttreeHybrid() #94

Closed
JShermanK1 opened this issue Mar 11, 2024 · 2 comments

Comments

@JShermanK1
Copy link

Thanks for all the work.

I'm trying to do findModules(deepSplit= 0) to get cuttreeHybrid(deepSplit= 0), but deepSplit is being passed to pickSoftThreshold() which results in got an unexpected keyword argument 'deepSplit' . Maybe take the user provided kwargs and only fill in the unspecified keys with default values, then you can parcel out kwargs to the appropriate function calls?

As a sidenote, the API documentation states that deepSplit defaults to 1, but when I dig into the code it appears that it is actually 2.

I am ultimately trying to see if broader clusters result in better gene set enrichment. Am I going about this in a naive manner?

@nargesr nargesr reopened this Mar 21, 2024
@nargesr
Copy link
Member

nargesr commented Mar 21, 2024

Hi @JShermanK1 , Sorry for the delay!
I just released the new version which hopefully solves your problem

findModules() is more like a wrapper function so I ended up changing the input a little bit.
please look at the API documentation and let me know if you have any problems/questions.

@JShermanK1
Copy link
Author

Hi @nargesr,

Thanks for the effort. The new keywords argument seems to be working so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants