PR: Catch Multiple Errors

[KyleKing]

Would you be open to a PR that catches multiple errors and prints them all at once?

I was thinking that instead of the raise AttributeError(), the errors could be collected and then raised at the end

abcmeta/abcmeta/__init__.py

Lines 157 to 187 in 4fef29b

	# Make sure the derived class has implemented the abstract method.
	if name not in cls.__dict__:
	raise AttributeError(
	"Derived class '{}' has not implemented '{}' method of the"
	" parent class '{}'.".format(
	cls.__name__, name, cls.__base__.__name__
	)
	)
	derived_method = getattr(cls, name)
	# Get methods signatures.
	*obj_method_signature, obj_method_signature_str = _get_signature(obj)
	*derived_method_signature, derived_method_signature_str = _get_signature(
	derived_method
	)
	# Compare signatures.
	diff = _compare_signatures(
	obj_method_signature_str, derived_method_signature_str
	)
	# Raise signature error.
	if diff:
	diff_details = _compare_signatures_details(
	obj_method_signature, derived_method_signature
	)
	raise AttributeError(
	"Signature of the derived method is not the same as parent"
	" class:\r\n{}".format(_prepare_text_to_raise(diff, diff_details))
	)

Could be modified like this:

errors = []
for name, obj in vars(cls.__base__).items():
    ...
    if name not in cls.__dict__:
        errors.append(
            "Derived class '{}' has not implemented '{}' method of the"
            " parent class '{}'.".format(
                cls.__name__, name, cls.__base__.__name__
            )
        )
        continue
    ...
if errors:
    raise AttributeError("\n\n".join(errors))

[mortymacs]

Hi Kyle,

That's an excellent idea! 👍
Would you please send a PR, or I prepare it myself?

[KyleKing]

Submitting now! Just adding a new test

[mortymacs]

Hi Kyle,

I just released the new version. Please check it and let me know if there is anything you need. :)

Cheers,
Mort

[KyleKing]

Perfect, thanks! The Windows support and error index are really nice additions