Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with SPH examples. #9

Open
tomashalada opened this issue Jan 18, 2024 · 0 comments
Open

Issues with SPH examples. #9

tomashalada opened this issue Jan 18, 2024 · 0 comments

Comments

@tomashalada
Copy link
Contributor

tomashalada commented Jan 18, 2024 •
edited
Loading

  • Examples 7_SPH_dlb_gpu_opt and 7_SPH_dlb_gpu_more_opt contain function vector_dist.merge that does not exist. This functions is used only for sensors (which are commented out) and it seems that sensors work also without this function.

  • The smoothing function Wab is wrong in interval 1 < r/h < 2 and produces negative values.

I will fix both soon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomashalada