Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #1850

Merged
merged 6 commits into from Jan 7, 2023
Merged

Fix typos #1850

merged 6 commits into from Jan 7, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 25, 2022 •
edited

What does this PR do?

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@cclauss cclauss requested a review from a team as a code owner December 25, 2022 18:47
dakinggg
dakinggg approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

mvpatel2000
mvpatel2000 approved these changes Jan 7, 2023
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fixes. Apologies for the delay -- codeowners have been out on PTO for holidays

@mvpatel2000 mvpatel2000 merged commit 6572b4e into mosaicml:dev Jan 7, 2023
@cclauss cclauss deleted the patch-1 branch January 7, 2023 13:08
bmosaicml pushed a commit to bmosaicml/composer that referenced this pull request Jan 9, 2023
@cclauss @dakinggg @bmosaicml
Fix typos (mosaicml#1850)
d06f73c 
* Fix typos

* rerun tests

Co-authored-by: Daniel King <daniel@mosaicml.com>
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cclauss @mvpatel2000 @dakinggg