Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove soft_cross_entropy #29

Closed
ajaysaini725 opened this issue Oct 21, 2021 · 1 comment
Closed

Remove soft_cross_entropy #29

ajaysaini725 opened this issue Oct 21, 2021 · 1 comment
Assignees
@anisehsani
Labels
enhancement New (engineering) enhancements, such as features or API changes.

Comments

@ajaysaini725
Copy link
Member

Motivation

As of this update in pytorch: pytorch/pytorch#61044, we no longer need our implementation of soft_cross_entropy in composer/models/loss.py and should remove it in favor of the one in pytorch.
@ajaysaini725 ajaysaini725 added the enhancement New (engineering) enhancements, such as features or API changes. label Oct 21, 2021
@anisehsani anisehsani self-assigned this Oct 26, 2021
@hanlint
Copy link
Contributor

hanlint commented Nov 3, 2021

We may still want our own implementation, so that older versions of pytorch are still supported.

@hanlint hanlint closed this as completed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anisehsani anisehsani

Labels
enhancement New (engineering) enhancements, such as features or API changes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ajaysaini725 @hanlint @anisehsani