Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 1.25.0 will no longer support comparison to string #740

Closed
CalCraven opened this issue Jun 26, 2023 · 3 comments
Closed

Numpy 1.25.0 will no longer support comparison to string #740

CalCraven opened this issue Jun 26, 2023 · 3 comments
Assignees

Comments

@CalCraven
Copy link
Contributor

Coming up on unintended behavior when we try to compare attributes of a parametric potential to a null string with determining what to write for XML handling.

The line in question only works for numpy<=1.24.3. Probably can fix this single line so unyt arrays are not compared to this null string, and we can avoid that becoming an issue.

if value != ""

@CalCraven CalCraven self-assigned this Jun 26, 2023
@CalCraven
Copy link
Contributor Author

Issue is being discussed in unyt via:
yt-project/unyt#431

@CalCraven
Copy link
Contributor Author

This is currently handled in GMSO by pinning to numpy<=1.24.3. I'm going to leave this issue open though, as a reminder that in the near future, we either need to get a fix on the unyt side, or fix our logic.

@daico007
Copy link
Member

Resolved after #764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants