Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] python package: including rust source files #146

Closed
kemingy opened this issue Jun 9, 2022 · 3 comments
Closed

[FIX] python package: including rust source files #146

kemingy opened this issue Jun 9, 2022 · 3 comments

Comments

@kemingy
Copy link
Member

kemingy commented Jun 9, 2022

I just found that this doesn't really fix this issue.

Python package is unpredictable. :(

Originally posted by @kemingy in #127 (comment)
@kemingy kemingy changed the title fix python package: including rust source files [FIX] python package: including rust source files Jun 9, 2022
@kemingy
Copy link
Member Author

kemingy commented Jun 9, 2022

Ref:

@kemingy
Copy link
Member Author

kemingy commented Jun 9, 2022

My bad. #127 already fixed it.

  • python setup.py bdist_wheel will build the "Built Distributions" that can run in users' machines
  • python setup.py sdist will build the "Source Distribution" that package the source files

Chech https://pypi.org/project/mosec/#files

@kemingy kemingy closed this as completed Jun 9, 2022
@lkevinzc
Copy link
Member

Learned this. BTW it looks good currently on PyPI:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kemingy @lkevinzc