Skip to content

Commit

Permalink
BUG NOTE: flush is called on resources that only differ by model or p…
Browse files Browse the repository at this point in the history
…pd (this information can't be idempotent).
  • Loading branch information
mosen committed Sep 6, 2012
1 parent a5209a5 commit de1b284
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/puppet/provider/printer/cups.rb
Expand Up @@ -41,7 +41,6 @@
# The instances method collects information through a number of different command line utilities because no single # The instances method collects information through a number of different command line utilities because no single
# utility displays all of the information about a printer's configuration. # utility displays all of the information about a printer's configuration.
def self.instances def self.instances

prefetched_uris = printer_uris prefetched_uris = printer_uris
provider_instances = [] provider_instances = []


Expand Down Expand Up @@ -193,6 +192,8 @@ def flush
when :present when :present
# Regardless of whether the printer is being added or modified, the `lpadmin -p` command is used. # Regardless of whether the printer is being added or modified, the `lpadmin -p` command is used.


# BUG: flush should never be called if only the model or PPD parameters differ, because lpstat can't tell
# what the actual value is.
options = Array.new options = Array.new


# Handle most parameters via string substitution # Handle most parameters via string substitution
Expand Down

0 comments on commit de1b284

Please sign in to comment.