Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is "append" to index an option #12

Closed
JohnOmernik opened this issue Feb 22, 2017 · 2 comments
Closed

Is "append" to index an option #12

JohnOmernik opened this issue Feb 22, 2017 · 2 comments
Labels

Comments

@JohnOmernik
Copy link

I am looking through both docs, code, and test usage, and perhaps I am missing something, but it appears the options are A. Index does not exist, and on a single run of elasticsearch_loader, you can load an entire index or B. Index does exist and you specified --delete therefore the existing index will be deleted. When you try to run elasticsearch loader on an index that already exists, but do not specify --delete, it fails with error: elasticsearch.exceptions.RequestError: TransportError(400, u'index_already_exists_exception')

Thus, my request, if possible, is "append" to existing index.

@moshe
Copy link
Owner

moshe commented Feb 22, 2017

Sure, this should be the default behaviur, maybe are you passing index-settings-file when you trying to update the existing index?

@moshe moshe added the question label Feb 22, 2017
@JohnOmernik
Copy link
Author

Ah, I am AM doing that! I didn't know that is what is causing that... perhaps a note in the help screen or readme that states that the index settings only needs to be provided when first creating the index.

Alternatively, if the index is exists, and --delete is NOT specified, perhaps we ignore the index-settings file and pass a warning to the user that since the index exists the settings are ignored. (or perhaps we grab the current settings and if they don't match what is passed, we fail out, otherwise, just append as is?) Lots of options with different levels of complexity, but thanks for pointing out my base mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants