Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow patch release range compatibility with lexical #5

Closed
mosheduminer opened this issue Feb 28, 2023 · 3 comments
Closed

Allow patch release range compatibility with lexical #5

mosheduminer opened this issue Feb 28, 2023 · 3 comments

Comments

@mosheduminer
Copy link
Owner

Currently, lexical-solid requires exact versions of all lexical dependencies. This decision was made because @lexical/react (which this package is a port of) may (need to) change concurrently with changes in the other lexical packages. So using newer lexical packages with lexical-solid would be akin to using a @lexical/react older than other lexical packages used.

However, I am now reconsidering this, to instead allow ranges of patch versions, as I think the likelihood of a newer patch version breaking an earlier @lexical/react of the same minor version is rather unlikely, and in the case it does happen, the end user could pin the packages.

This will allow users of lexical-solid to get use bug fixes from upstream lexical much faster, as they won't need to wait for this package to update and release.

@acywatson
Copy link

I think this should be OK - there shouldn't be breaking changes between the patch versions.

@mosheduminer
Copy link
Owner Author

Thanks for confirming @acywatson 🙏.

@mosheduminer
Copy link
Owner Author

Resolved by 80c9719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants