Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't detect FFMpeg installation through brew #32

Closed
antwake opened this issue May 19, 2019 · 9 comments · Fixed by #34
Closed

Doesn't detect FFMpeg installation through brew #32

antwake opened this issue May 19, 2019 · 9 comments · Fixed by #34
Assignees
@moshfeu
Labels
bug Something isn't working good first issue Good for newcomers
Projects
App
Milestone
v1.7.0

Comments

@antwake
Copy link

antwake commented May 19, 2019

Describe the bug
When starting the app, it says "FFMpeg is not installed" even if FFMpeg is installed.

To Reproduce
Steps to reproduce the behavior:

  1. Open terminal
  2. Type brew install ffmpeg
  3. Confirm FFMpeg is installed with ffmpeg -version
  4. Open Y2MP3
  5. Says "FFMpeg is not installed :("

Add logs from DevTools
ffmpegPath app.bundle.js:28
isFFMpegInstalled app.bundle.js:33

Expected behavior
Y2MP3 should detect FFMpeg

Screenshots
Screen Shot 2019-05-19 at 16 13 54

  • OS: MacOS
  • Version Mojave
  • App Version 1.4.0

Additional context
Might be a feature request if you expect us to install FFMpeg through the "classic" dmg way
@antwake antwake added the bug Something isn't working label May 19, 2019
@moshfeu moshfeu added the good first issue Good for newcomers label May 20, 2019
@moshfeu moshfeu added this to To do in App via automation May 20, 2019
@moshfeu moshfeu added this to the v1.7.0 milestone May 20, 2019
@moshfeu
Copy link
Owner

moshfeu commented May 20, 2019

Thank you!

@moshfeu moshfeu moved this from To do to In progress in App May 28, 2019
@moshfeu moshfeu mentioned this issue May 29, 2019
Merged
@moshfeu
Copy link
Owner

moshfeu commented May 29, 2019

@antwake if you can review the PR (at least the assumption there) this will be awesome.
Thanks!

@antwake
Copy link
Author

antwake commented May 29, 2019

Sounds right! (for the assumption 🙂)

Thank you

@moshfeu
Copy link
Owner

moshfeu commented May 29, 2019

Great. Thank you!

App automation moved this from In progress to Done May 30, 2019
@moshfeu
Copy link
Owner

moshfeu commented Jun 2, 2019

I published a new version. Can you check if it's working for you?
https://github.com/moshfeu/y2mp3/releases/tag/v1.7.0
Thanks!

@antwake
Copy link
Author

antwake commented Jun 2, 2019

Works perfectly 🙏🏼

Thanks!

@moshfeu
Copy link
Owner

moshfeu commented Jun 3, 2019

Thanks!

@moshfeu
Copy link
Owner

moshfeu commented Jun 3, 2019

Can I tag you in a tweet about the new version? If so, what's your twitter id?
Thanks

@antwake
Copy link
Author

antwake commented Jun 3, 2019

Yeah, definitely! https://twitter.com/tochepa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moshfeu moshfeu

Labels
bug Something isn't working good first issue Good for newcomers
Projects
App
  
Done
Milestone
v1.7.0
Development

Successfully merging a pull request may close this issue.

Use installed FFMPEG if it exists in PATH moshfeu/y2mp3
2 participants
@antwake @moshfeu