Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Wrong matrix power? #2

Open
jacobhilton opened this issue Dec 17, 2019 · 2 comments
Open

Wrong matrix power? #2

jacobhilton opened this issue Dec 17, 2019 · 2 comments

Comments

@jacobhilton
Copy link

jacobhilton commented Dec 17, 2019

In your pseudocode, you take H_t^i to the power -1/(2k), but in your code you take precond to the power -1 / order, not -1 / (2 * order). Is this a bug or am I missing something?

@moskomule
Copy link
Owner

Hi, thank you for reporting. I implemented Shampoo long ago, so I don't remember why I did so.
If you find this is a critical, could you send me a PR?

@jacobhilton
Copy link
Author

Thanks for your reply. I don't plan to use this in the future so it is not critical for me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants