Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dump文件多余(.)逗号. #99

Closed
AtlanCI opened this issue May 23, 2022 · 7 comments
Closed

dump文件多余(.)逗号. #99

AtlanCI opened this issue May 23, 2022 · 7 comments

Comments

@AtlanCI
Copy link
Contributor

AtlanCI commented May 23, 2022

1653288560294_55A35748-CF59-4793-A824-9C8EEA87F574
如图,dump文件名字第一个字段后有两个点,请问这里是一个问题还是说这里应该填写用户指定的字符串。如果是用户指定字符串,如何指定没看到相关API

@doujiang24
Copy link
Member

这里没有特别的含义,也不是让用户指定呢

这个 .. 中间应该是 event id,比如 gcheap profile 这样的:h.writeProfileDataToFile(buf, thread, eventID)
只是 cpu 这种的,event id 是空字符串,""
也可以优化一下的,把这里的 .. 改为一个 .
你有兴趣提个 PR 不?应该改动也不大

@AtlanCI
Copy link
Contributor Author

AtlanCI commented May 24, 2022

好的 我尝试一下。 要不要为何和其他接口一致把这里也改成eventID? 我在用的时候其他的接口生成的也是..没有eventId的内容。eventID 好像没有暴露给用户。(这好像是一个问题)

1653288574786_3F297B29-8F0A-4f56-AB1D-9608D4B0D0A8

@doujiang24
Copy link
Member

👍🏻

event ID 只是因为 gcheap 需要两个 profile,做前后 diff
对于,其他类型,event ID 确实没啥意义

另,在 reporter 接口里,是有暴露 event ID 的

@AtlanCI
Copy link
Contributor Author

AtlanCI commented May 24, 2022

我看到了在提供http报告的地方 有暴露接口。 我将尝试提一个PR以修改CPU,MEM,Gourtinedump文件的..

@AtlanCI
Copy link
Contributor Author

AtlanCI commented May 25, 2022

#100 我提交了一个PR 我发现evntID在dump文件路径是全局传递的,不太好改。 所以我在底层直接改了文件名的格式

@doujiang24
Copy link
Member

@AtlanCI 这是合适的改法,已经合并了,感谢~

@AtlanCI
Copy link
Contributor Author

AtlanCI commented May 25, 2022

客气啦 也没做啥 也感谢您 我将关闭这个issue

@AtlanCI AtlanCI closed this as completed May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants