Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicResourcesController returns relative instead of absolute URL #133

Closed
zepich opened this issue Sep 7, 2023 · 1 comment
Closed

DynamicResourcesController returns relative instead of absolute URL #133

zepich opened this issue Sep 7, 2023 · 1 comment
Assignees
@zepich
Labels
bug Something isn't working

Comments

@zepich
Copy link
Member

zepich commented Sep 7, 2023

If the stylesheet cache is unavailable for a project (or the cache is invalid), the DynamicResourcesController returns to the default stylesheet. But the returned URL is relative instead of absolute. Then it leads to problems on the other side, for example, in a WordPress website, because the plugin tries to load the relative URL from the WordPress site (wordpress.example.com/build/mosparo-frontend.css) instead of the mosparo site (mosparo.example.com/build/mosparo-frontend.css).

https://github.com/mosparo/mosparo/blob/master/src/Controller/DynamicResourcesController.php#L73
@zepich zepich added the bug Something isn't working label Sep 7, 2023
@zepich zepich self-assigned this Sep 7, 2023
@zepich
Copy link
Member Author

zepich commented Sep 10, 2023

Fixed with v1.0.1

@zepich zepich closed this as completed Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepich zepich

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepich