Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing os.O_BINARY for Windows in func parse_mode #35

Closed
honglei opened this issue Jun 19, 2020 · 1 comment
Closed

missing os.O_BINARY for Windows in func parse_mode #35

honglei opened this issue Jun 19, 2020 · 1 comment

Comments

@honglei
Copy link
Contributor

honglei commented Jun 19, 2020

It should be :

        if m == 'b':
            binary = True
            if 'nt' == os.name:
                flags |= os.O_BINARY
@honglei
Copy link
Contributor Author

honglei commented Jun 19, 2020

sorry, I used 0.5.3, I see the master version already solved this , please release a new version in pip, Many Thanks!

@honglei honglei closed this as completed Jun 19, 2020
@honglei honglei mentioned this issue Jun 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@honglei