Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotenv crashes on commented lines #10

Closed
jessefulton opened this issue Nov 15, 2013 · 0 comments · Fixed by #11
Closed

dotenv crashes on commented lines #10

jessefulton opened this issue Nov 15, 2013 · 0 comments · Fixed by #11
Assignees
@jessefulton

Comments

@jessefulton
Copy link
Contributor

Given the following .env

BASIC=basic
SINGLE_QUOTES='single_quotes'
DOUBLE_QUOTES="double_quotes"
EXPAND_NEWLINES="expand\nnewlines"
DONT_EXPAND_NEWLINES_1=dontexpand\nnewlines
DONT_EXPAND_NEWLINES_2='dontexpand\nnewlines'
ENVIRONMENT_OVERRIDE=production
# COMMENTS=work
EQUAL_SIGNS=equals==

Anything after # COMMENTS in that file will be ignored. The problem is that the regex doesn't match so line 20 throws an error which is caught outside of the for loop in _getKeysAndValuesFromEnvFilePath and the loop stops. I should have a patch in a few.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessefulton jessefulton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix commenting lines out .env files jessefulton/dotenv
1 participant
@jessefulton