-
-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.env.$NODE_ENV override no longer working after updating to > 1.x #80
Comments
Seems support for that was dropped when doing the 1.0.0 overhaul. Reverting to 0.5.1 works. |
If you want to stay on
|
@motdotla that wont work, before 1.x we used to be able to "override" by providing .env along side a .env.test. For example, setting different database options in .env.test for when running with NODE_ENV=test, while still using all the other settings from .env. What you recommend would simply load .env.test instead of .env, not "override" the values from .env with those in .env.test. |
@motdotla @maxbeatty do you mind keeping this issue open until this is fixed? This is a regression in 1.x. Or do you have no plan for supporting this anymore and officially dropping this from 1.x? Are you open to pull requests, etc.? Please reopen the issue. Thanks |
@siboulet I don't think we are going to supporting this anymore. I know we are, for sure, not adding back |
This is not a regression. We follow semver for versioning, and This module respects var dotenv = require('dotenv');
dotenv.config({path: '.env.test'}); // most important values
dotenv.config({path: '.env'}); // fill in the gaps Since we've covered this topic multiple times, I'm going to add it to the FAQ |
Thanks for the thorough explanation. This make sense now. And for anyone that really needs to have the override feature and 1.x, she can always use the successive calls to dotenv.config() as mentioned in the comment above. That works for me. Also might worth removing the mention of .env.$NODE_ENV here to remove any confusion: https://github.com/motdotla/dotenv/blob/master/lib/main.js#L7 Thanks |
I believe comment
Should be changed to account for this breaking change - tried to make |
main.js is mentioning "Allows configuration before loading .env and .env.$NODE_ENV".
I can't get per-environment config to work. Ex. starting my node app with NODE_ENV=test doesn't seems to load .env.test.
I'm trying to override some defaults in .env by using .env.test for some config that need to apply only when running tests ex. setting a different database when NODE_ENV is "test".
The text was updated successfully, but these errors were encountered: