Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds inappropriate resources into zip #4

Closed
StoneCypher opened this issue Jan 17, 2016 · 7 comments
Closed

Builds inappropriate resources into zip #4

StoneCypher opened this issue Jan 17, 2016 · 7 comments

Comments

@StoneCypher
Copy link
Contributor

Default project builds dependencies of node-lambda into lambda zipfile. Hello world now carries commander, graceful-readlink, sax, xml2js, xmlbuilder, etc. ~771k of deps.

@StoneCypher
Copy link
Contributor Author

I kind of wonder if this is about node's new flat dep trees

@DeviaVir
Copy link
Collaborator

DeviaVir commented Apr 25, 2017

Not entirely sure what this feedback means or what you'd like to see fixed, or if it's still broken.

Please comment/reopen with more details. Closing due to inactivity.

@StoneCypher
Copy link
Contributor Author

Basically "why are you building all these libraries I'm not using into my lambda deploy, these are things you use, not things I use"

If you write hello world as a lambda, commander and xml2js should not be part of the deployed build

It's generally poor practice to close issues before understanding them

@DeviaVir
Copy link
Collaborator

@StoneCypher got ya, so these libraries are pulled in for use by node-lambda. If you see a way to deploy without these, please feel free to open a PR (or naturally another issue) in https://github.com/motdotla/node-lambda. Thanks!

@StoneCypher
Copy link
Contributor Author

Please re-open the issue until it's addressed

@StoneCypher
Copy link
Contributor Author

When this project inevitably passes hands to a new maintainer, they'll want to know about the serious defects this project contains

closed is not the correct status for things you don't want to investigate

@DeviaVir
Copy link
Collaborator

That's absolutely not the case here, I have pointed out where your issue should live, and this is simply not the place for it. I appreciate the feedback.

Repository owner locked and limited conversation to collaborators Apr 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants