Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept SCP-like URL (git@github.com) for import command #35

Merged
merged 1 commit into from
Sep 23, 2014
Merged

accept SCP-like URL (git@github.com) for import command #35

merged 1 commit into from
Sep 23, 2014

Conversation

mkanai
Copy link
Contributor

@mkanai mkanai commented Sep 13, 2014

  • url.Parse doesn't handle SCP-like URL (e.g. git@github.com) properly.
fatal: invalid URL scheme name or missing '://' suffix
     error exit status 128
  • now, ghq import < FILE clones repos into .ghq/git@github.com:user/repo.
  • substituted url.Parse with NewURL, which accepts SCP-like URL as doGet currently implemented.

@motemen
Copy link
Member

motemen commented Sep 23, 2014

Good catch. Thanks!

motemen added a commit that referenced this pull request Sep 23, 2014
@motemen
Merge pull request #35 from mkanai/accept_git@github.com_for_import
3a47e08 
accept SCP-like URL (git@github.com) for import command
@motemen motemen merged commit 3a47e08 into x-motemen:master Sep 23, 2014
@mkanai mkanai deleted the accept_git@github.com_for_import branch October 3, 2014 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkanai @motemen