Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ViewNameParser #286

Closed
joeholdcroft opened this issue Dec 23, 2013 · 0 comments
Closed

Refactor ViewNameParser #286

joeholdcroft opened this issue Dec 23, 2013 · 0 comments
Labels

Comments

@joeholdcroft
Copy link
Contributor

  • It does too much. Consider moving a bunch of this logic elsewhere.
  • The "default dirs" functionality seems backwards. Could it not just be an array of directories to check in? Then the view override dir can be at the end and it will then always replace the views in that way.
    • Alternatively could we do something where things can add functions that are passed the parsed reference instance. Then Cog could define a declaration to look for the standard view, and a view override also?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants