Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate commitlint. #16

Closed
Ross-Esmond opened this issue Aug 2, 2022 · 2 comments
Closed

Integrate commitlint. #16

Ross-Esmond opened this issue Aug 2, 2022 · 2 comments
Assignees
Labels
b-enhancement New feature or request

Comments

@Ross-Esmond
Copy link
Contributor

Bring in Commitlint for both local pre-checks and a GitHub actions failure. They have a config for Angular-style commit messages that will catch the most common issues.

Considered alternatives
None. Commitlint appears to be the most popular commit message checker on npm by a wide margin.

Additional context
This will help to avoid having to "confront" people about their commit messages if they miss the guide.

@Ross-Esmond Ross-Esmond added the b-enhancement New feature or request label Aug 2, 2022
@Ross-Esmond
Copy link
Contributor Author

I think #3 should also happen. I have definitely forgotten to rerun some of the commands before pushing a few times now. A local error saves a lot of time, even when you know what you're doing. Catching a bad commit message before the commit saves a ton of time in particular.

@aarthificial aarthificial self-assigned this Aug 2, 2022
@aarthificial aarthificial transferred this issue from another repository Aug 3, 2022
@aarthificial
Copy link
Contributor

aarthificial commented Aug 3, 2022

Done in 6c8d190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b-enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants