-
-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improper cloning of custom fields #925
fix: improper cloning of custom fields #925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this.transform('get')
should also include customFields
, just like how serialize
does.
I'm not sure how much sense it makes to include custom fields in the transform itself, given that any calls to |
Apologies for the confusion. I meant that the place where protected handleChange = () => {
if (this.ignoreChange) return;
this.value.current = {
...this.transform('get'),
...this.customFields,
};
}; |
This reverts commit 63fd64c.
Awesome, thanks for the fix! |
Fixes a bug where
MetaObjectField
passes custom fields into the constructor after callingclone
, causing the editor to crash due to missing.get()
methods on the custom fields.