feat(2d): code bounding box helpers #948
Merged
+227
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarthificial
force-pushed
the
code-bbox-helpers
branch
from
87a4a4c
to
66f870c
Compare
hhenrichsen
reviewed
Feb 9, 2024
| @@ -368,7 +376,123 @@ export class Code extends Shape { | |||
| * @param pattern - Either a string or a regular expression to match. | |||
| */ | |||
| public findLastRange(pattern: string | RegExp): CodeRange { | |||
| return findAllCodeRanges(this.parsed(), pattern).at(-1) ?? [[0, 0], [0, 0]]; | |||
| return ( | |||
| findAllCodeRanges(this.parsed(), pattern).at(-1) ?? [ | |||
There was a problem hiding this comment.
Is there optimization we should worry about here? Normally findLast or findFirst are used to avoid a full string iteration if possible, although I'm not sure it's worth it here.
There was a problem hiding this comment.
I don't know how to do that while supporting regex tbh.
The function is mainly for convenience but I'm always open to optimization propositions.
hhenrichsen
reviewed
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.