Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add color picker popover to color input #962

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

jmaen
Copy link
Contributor

@jmaen jmaen commented Feb 21, 2024

Add a color picker popover to the color input component. It can be opened by clicking the color preview.

grafik

@jmaen
Copy link
Contributor Author

jmaen commented Mar 19, 2024

Is there something that you want me to change @aarthificial ?

@aarthificial
Copy link
Contributor

Apologies, I got distracted by the next release.
I pushed a tiny commit with some style adjustments to make the color input consistent with the input select (the color box is now a separate button):
image

Other than that the only problem left is the fact that the width of scrollbars is different on Chrome than on Firefox which makes the picker misaligned on Chrome:
image

@jmaen
Copy link
Contributor Author

jmaen commented Mar 20, 2024

No worries :) The alignment shoult be fixed now.

@aarthificial aarthificial merged commit 5ed7669 into motion-canvas:main Mar 21, 2024
9 checks passed
@aarthificial
Copy link
Contributor

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants