Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for OAuth Server Name #181

Closed
JuricDavor opened this issue Nov 13, 2017 · 4 comments
Closed

Add validation for OAuth Server Name #181

JuricDavor opened this issue Nov 13, 2017 · 4 comments
Assignees

Comments

@JuricDavor
Copy link

JuricDavor commented Nov 13, 2017

[Add validation for OAuth Server Name. if you add a name of a server which already exist you are able to save that changes. Although the server is not created you are receiving a popup with a success message ]

Reproduction Steps:

  1. [Log in > Navigate to OAuth Servers]
  2. [Create a new OAuth Servers]
  3. [Fill OAuth Server Name input field which already exist ]

User should not be able to save changes. Error message should appear in a popup that this Server Name already exist:

[Describe expected behavior here]

When clicking on Create a OAuth Server popup appears with the successful message. Although the actual server is not created we should not show popup with successful message.

oath server 1
oauth server 4
oauth server 3
oauth server 2

@ivanzusko ivanzusko self-assigned this Nov 13, 2017
@ivanzusko
Copy link
Contributor

Thank you, @JuricDavor !

@ivanzusko ivanzusko reopened this Nov 15, 2017
@ivanzusko
Copy link
Contributor

@rafaeljesus , Senior, por favor, can you check this out? Seems like when we are creating the new item with the same name - it's merging to elements into one...

@s4nji
Copy link
Contributor

s4nji commented Nov 17, 2017

@ivanzusko the issue you mentioned has been fixed 🙂

@ivanzusko
Copy link
Contributor

Awesome! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants