Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on underscore missing? #2

Closed
JockeCK opened this issue Feb 2, 2016 · 4 comments
Closed

Dependency on underscore missing? #2

JockeCK opened this issue Feb 2, 2016 · 4 comments

Comments

@JockeCK
Copy link

JockeCK commented Feb 2, 2016

It seems you are depending on the library underscore for functions such as "_.isNumber".

However, there is no trace of this dependency in your code/json?

Personally I would love an solution that does not depend on underscore.
Like:
function isNumeric(n) {
return !isNaN(parseFloat(n)) && isFinite(n);
}
(example, just an quick google)
Since you at an glance don't seem to depend all that heavily upon the library. But obviously up to you.

@motss
Copy link
Owner

motss commented Feb 2, 2016

@JockeCK This might due to the fact that I'm a Lodash user. I always use the library with Polymer even though you can achieve something in Javascript without the need of Lodash just like what you mentioned earlier. Thus, instead of including the <script src="../lodash/dist/lodash.min.js"></script> inside the element, I think I should load the script at top level document which means that you can find the script tag inside the demo/index.html. Well, Lodash is a great library and if you have web-component-tester installed, you will probably get the Lodash installed as well.

@JockeCK
Copy link
Author

JockeCK commented Feb 2, 2016

Thank you for the quick explanation!

Got your component up and running after adding pathway to bower installation of lodash.

@motss
Copy link
Owner

motss commented Feb 2, 2016

Cool!

@motss motss closed this as completed Feb 9, 2016
@motss motss reopened this Feb 12, 2016
@motss
Copy link
Owner

motss commented Feb 29, 2016

No longer depend on Lodash. See commit 89777d3.

@motss motss closed this as completed Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants