Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envvars vs envvars.sample #33

Open
mottaquikarim opened this issue Jul 1, 2018 · 0 comments
Open

envvars vs envvars.sample #33

mottaquikarim opened this issue Jul 1, 2018 · 0 comments
Labels
good first issue Good for newcomers

Comments

@mottaquikarim
Copy link
Owner

Currently, we have an envvars.sample that is supposed to be a template for any required / important envvars that docker environment needs to run.

As of now, this is mainly empty, project is super simple rn but if we ever wanted to pull out envvars from Travis CI and pipe into build, this would be the way to do it.

The main issue is, docker requires envvars file, not envvars.sample, the sample extension exists mainly to discourage accidental pushes of sensitive secrets to scm. This should not be a problem when using make and npm-scripts targets for various processes, but it may become an issue if one wants to run docker compose cmds directly /do something custom.

The ALTERNATIVE would be to simple commit envvars to SCM and tack on a bid ol' warning on top of file to NOT commit sensitive material.

Whatdoyathink? I can go both ways.

@mmosayed? Anyone else? (@crymall already looked at this, wanted to defer to community at large).

@mottaquikarim mottaquikarim added the good first issue Good for newcomers label Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant