Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'UseKeychain' #189

Merged
merged 2 commits into from
Jan 8, 2017
Merged

Conversation

ocean90
Copy link
Contributor

@ocean90 ocean90 commented Jan 7, 2017

macOS Sierra 10.12.2 includes an new option called UseKeychain:

$ man ssh_config
     UseKeychain
             On macOS, specifies whether the system should search for passphrases in the user's keychain when attempting to use a par-
             ticular key. When the passphrase is provided by the user, this option also specifies whether the passphrase should be
             stored into the keychain once it has been verified to be correct.  The argument must be ``yes'' or ``no''.  The default is
             ``no''.

Disclaimer: I don't know Go and don't know how to run the tests. :) Tests are passing 馃挭馃徏

@moul moul added this to the v2.6.0 milestone Jan 8, 2017
@moul
Copy link
Owner

moul commented Jan 8, 2017

Hi @ocean90, thank you for this PR, and congratulations, everything seems good to me ;)

@moul moul merged commit 737388c into moul:master Jan 8, 2017
@ocean90 ocean90 deleted the feature/usekeychain branch January 8, 2017 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants