Invalid multiplex command on Ubuntu 18.04

[pschmitt]

When using the native ssh client on Ubuntu 18.04 assh invokes an invalid ssh command (ssh -o false -O false test.example.com)

Example:

$ /usr/bin/ssh -V
OpenSSH_7.6p1 Ubuntu-4ubuntu0.3, OpenSSL 1.0.2n  7 Dec 2017
$ assh --config /dev/null -D --verbose wrapper ssh test.example.com                                                                                                                          
2019-09-22T14:42:27.650+0200	DEBUG	assh.pkg.commands	commands/wrapper.go:62	Wrapper called	{"bin": "/usr/bin/ssh", "target": "test.example.com", "command": [], "options": ["-O", "false", "-o", "false"], "sshArgs": ["ssh", "-O", "false", "-o", "false", "test.example.com"]}
2019-09-22T14:42:27.650+0200	DEBUG	assh.pkg.config	config/config.go:518	Loading config file	{"file": "/dev/null"}
2019-09-22T14:42:27.651+0200	DEBUG	assh.pkg.config	config/config.go:536	Loaded config file	{"file": "/dev/null", "num-host-before": 0, "num-host-after": 0, "num-host-diff": 0}
Invalid multiplex command.

[pschmitt]

I managed to fix it with this:

diff --git pkg/commands/wrapper.go pkg/commands/wrapper.go
index 71af6314..65e9c474 100644
--- pkg/commands/wrapper.go
+++ pkg/commands/wrapper.go
@@ -46,6 +46,14 @@ func runSSHWrapperCommand(cmd *cobra.Command, args []string) error {
 	}
 	for _, flag := range config.SSHStringFlags {
 		for _, val := range viper.GetStringSlice(flag) {
+			if (flag == "o" || flag == "O") && val == "false" {
+				logger().Debug(
+					"Skip invalid option:",
+					zap.String("flag", flag),
+					zap.String("val", val),
+				)
+				continue
+			}
 			options = append(options, fmt.Sprintf("-%s", flag))
 			options = append(options, val)
 		}

[github-actions]

🎉 This issue has been resolved in version 2.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀