You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently for POST requests, any supplied URL query parameters do not appear in rack.request.params. This means that for HMAC signature verification to work, those parameters have to be hacked into the request body. We would prefer to keep the signing params in the URL.
We should be able to use Etna::ParseBody to get all the params, regardless of where they are located. The Etna::Auth should use that implementation.
The text was updated successfully, but these errors were encountered:
I.e., ParseBody will automatically stuff things into rack.request.params from wherever they might originate before Etna::Auth runs, allowing the latter to get whatever it needs from params. If params aren't showing up there is perhaps some other explanation.
Currently for POST requests, any supplied URL query parameters do not appear in
rack.request.params
. This means that for HMAC signature verification to work, those parameters have to be hacked into the request body. We would prefer to keep the signing params in the URL.We should be able to use
Etna::ParseBody
to get all the params, regardless of where they are located. TheEtna::Auth
should use that implementation.The text was updated successfully, but these errors were encountered: