Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statuses should automatically format links and mentions into html #377

Closed
7 tasks
mouse-reeve opened this issue Dec 7, 2020 · 2 comments · Fixed by #409
Closed
7 tasks

Statuses should automatically format links and mentions into html #377

mouse-reeve opened this issue Dec 7, 2020 · 2 comments · Fixed by #409
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mouse-reeve
Copy link
Member

mouse-reeve commented Dec 7, 2020

Right now, if you post a link, it remains plain text. If you @ mention a user, same thing. When a status is created, it should:

  • detect links and turn them into a tags
  • detect @ mentions
    • use the user database to resolve mentions
    • use webfigner to resolve unknown mentions
    • format known mentions with an a tag, leave unknown ones as plain text
    • add mentioned users to the mentions_user database field
    • tag the user as mentioned in the activitypub object (this should happen automatically without any code change if the database field is set but I'm putting it in this list to be thorough)
@mouse-reeve mouse-reeve added enhancement New feature or request good first issue Good for newcomers labels Dec 7, 2020
@rkingett
Copy link

rkingett commented Dec 7, 2020

Could we include markdown support in these statuses as well as linking to books? Like, if I @ a book could we link that too? Or would that not work for the database? I also just like Markdown.

@mouse-reeve
Copy link
Member Author

yes! supporting markdown is already in the roadmap (#37), and it didn't occur to me to let people tag books but it should definitely be possible. I think the simplest implementation of @ mentioning a book would be to turn a url that links to a book into a mention, since that's the most obvious unique identifier of a book. It would be better to allow a user to start typing a title and get suggestions, but that's another level of complexity (which should happen, but maybe not in the scope of this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants