-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add French translation #665
Conversation
Some translators might translate this as “éditer” when the proper translation is “modifier”.
- Add strings which need narrow non-breakable space. - Add strings about “privacy” (“confidentialité” from Mastodon). - Add strings about “curation” (“modération”). - Add strings about “follower” (“abonné” from Mastodon). - Add strings for “ reading goal” (“défi lecture”).
By the way, I added the file manually. Running the command in the README gave me the following: me@computer:~/Projects/bookwyrm$ ./bw-dev makemessages -l fr
+ case "$CMD" in
+ django-admin makemessages --extension html --ignore=venv3 -l fr
./bw-dev: line 94: django-admin: command not found |
hmm, it works for me, so I wonder if there's a configuration step I failed to document to make the |
Speaking as someone who knows zero French, this looks great! I'm going to go through the UI and improve the spots you pointed out, and now that there's a translation in place, it's much easier to see the things in the UI I missed. My only requested change is the missing quotes :) I really appreciate how promptly and thoroughly you did this! Thank you! |
Ha, damn! I searched for an easily accessible gettext linter and did not find anything that worked or that wouldn’t take me less than 5 minutes to install.
I’ll update that tomorrow.
|
okay I went through and fixed the obvious places I missed template translations, changes are in #666. I didn't find a super obvious solution to why the django-admin command failed, it sounds like it might be platform dependent? (https://stackoverflow.com/questions/8250086/command-not-found-django-admin-py)
I'm not sure that there's a good template-level fix for this, since that texts is preceded by a username, so there's no way to know the gender of the subject. All my support for the English singular 'they" isn't much use in a language with grammatical gender :) If getting the |
A very wild guess tells me you’re on Windows. I’m on Linux. I don’t know what would happen on Mac; I would suspect something closer to Linux than Windows.
The problem is more about the object than the subject in that case. In the context of the example I gave:
Yes please; I have no habits working with Docker or Python, so debugging the environment would take me a fair amount of time. From what I checked, there is no sign of django-admin being installed when following the steps in the README. |
right! object not subject, that makes much more sense. I'll try and fix those |
I think #667 will fix the problems with |
Github doesn't supporting uploading .po files (probably a reasonable call), but I can send you the version updated to reflect #666 through whatever means works best for you if the |
Hello…
I’m not entirely happy with things like “URL pour soutenir l’instance” but unless there is a paragraph to describe what the context of “support” is, I found it hard to make it shorter.
Also… "Texte affiché lorsque les enregistrements sont clos :" is a bit mouthful but, for now, I take it as a good way to see if the UI is solid enough. :)
I used “Comptes” (accounts) for users as it is more gender‑neutral. It would be utilisateurs et utilisatrices otherwise. Mastodon is doing the same.
I didn’t test thoroughly but it should be a fairly safe start already. I think the following could cause some issues:
in a <a href=\"%(related_path)s\">%(preview_name)s</a>
will be problematic with gender‑based languages like French, Spanish and many others. a can be un or une depending on the gender of the object.Let me know. :)