Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dice Roller not working for XdY x Z #17

Open
mouse0270 opened this issue Jul 25, 2018 · 4 comments
Open

Dice Roller not working for XdY x Z #17

mouse0270 opened this issue Jul 25, 2018 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mouse0270
Copy link
Owner

LtDarien from D&D Beyond

Having a problem with the Dice Roller, but only for XdY * Z rolls, such as for gold. You can see many of those rolls on this page: https://www.dndbeyond.com/compendium/rules/dmg/treasure#TreasureTables

When you click, the Roller pops up but it just says "{0}"

@mouse0270 mouse0270 added bug Something isn't working good first issue Good for newcomers labels Jul 25, 2018
@mouse0270 mouse0270 self-assigned this Jul 25, 2018
@kalebhermes
Copy link

I believe this issue is complete now, is that correct?

@mouse0270
Copy link
Owner Author

mouse0270 commented Aug 8, 2018

This issue is corrected in the new update. I am still testing it but do think I am pushing it live tomorrow.

I will probably leave this open or create a new issue because I really need to update my dice rolling script because the generic one I am using it starting to get kinda patched together

@kalebhermes
Copy link

Ah it's fixed for me locally because I've pulled your latest code and deployed it haha, that makes sense! It seems to be working for me, with everything I've tested so far!

@mouse0270
Copy link
Owner Author

Yup, if you are running the most "beta" / GitHub version you will always get my slightly buggy in test version. lol

I am still working on improving the GitHub and Character Theme Options. This works pretty well but as I said I need to look into building my own dice roller script so it fits my needs more. Right now I am ghetto patching the one I am using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants