Get rid of "shutdown" methods because of Apple issues #758
Conversation
| @@ -206,7 +206,7 @@ class DynamicTextureAtlas | |||
|
|
|||
| /// Clear out the active dynamic textures. Caller deals with the | |||
| /// change requests. | |||
| void shutdown(ChangeSet &changes); | |||
| void teardown(ChangeSet &changes); | |||
There was a problem hiding this comment.
@mousebird this seems a bit confusing to me. DynamicTextureAtlas already has a cleanup() method, so now we have both cleanup() and teardown().
I'd say both methods are quite similar, the only different is cleanup() only removes the texture if it has regions. Can we merge both methods together in one single cleanup() one?
There was a problem hiding this comment.
cleanup() isn't a shutdown method. It destroys textures we're no longer using and is run regularly. teardown() seems like a good name.
| @@ -55,7 +55,7 @@ - (void)cleanup | |||
| [self performSelector:@selector(cleanup) withObject:nil afterDelay:kWKParticleSystemCleanupPeriod]; | |||
| } | |||
|
|
|||
| - (void)shutdown | |||
| - (void)teardown | |||
There was a problem hiding this comment.
@mousebird Similar confusion here. Can we merge cleanup() and teardown() methods in a single one?
There was a problem hiding this comment.
Nope! I like the name teardown()
There was a problem hiding this comment.
I reverted the latest commit, so everything it teardown() now
…ardown” when possible" This reverts commit fdcbe46.
No description provided.