New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing methods suggested on issue #103. #104
Conversation
lorem : 3 | ||
}; | ||
values(obj); // [1, 2, 3] | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a line break at the end of the file (might cause errors on some systems)
also need to make sure we test the behavior for nested properties like: {
"lorem_ipsum" : {
"dolor_sit" : "amet"
}
} see comment for more details on proposed feature/implementation |
I would like to ask you guys what's best here... Should I create individual modules for "deep" mapping keys ( |
Not really up to me. But I would say, before you make it a Boolean why don't you make it an integer that defines the levels of how deep you go. So only the first level would be However, I'm fine with two packages. |
I would also implement with a |
I moved this to the v0.8 milestone (that should be released next month) since @rafaelrinaldi and myself are busy and v0.7 is schedule for this week (and we already delayed it for too long). |
Visiting this again, it seems that Any thoughts? |
@conradz I agree. It's not hard to implement and can be useful in many cases. Just not sure if we need 2 methods or if we should accept |
@conradz @millermedeiros Should I then ditch everything but |
I would be 👍 on only having |
@conradz yeah, I agree; we use 2 methods everywhere, let's keep it consistent. - |
closing this since we probably just want a |
List of modules implemented:
object/camelCaseKeys
object/hyphenateKeys
object/mapKeys
object/underscoreKeys
Tests are passing and the documentation was also updated.
closes #103