Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in collection methods #183

Open
kamicane opened this issue May 22, 2014 · 2 comments
Open

Inconsistencies in collection methods #183

kamicane opened this issue May 22, 2014 · 2 comments
Labels

Comments

@kamicane
Copy link

  1. The methods collection/map and collection/filter don't use the collection/make_ utility to switch between object/method and array/mehtod. The iterator functions are provided with numerical indices and an array is always returned.
  2. collection/reject and collection/pluck should be fine once filter and map use make_
  3. This is really minor but make_ could use lang/isNumber instead of typeof, to avoid using array iterators on objects like {length: NaN}
@millermedeiros millermedeiros added this to the v0.10.0 milestone May 22, 2014
@millermedeiros millermedeiros removed this from the v0.10.0 milestone Sep 2, 2014
@millermedeiros
Copy link
Member

going to move this into next release.. we waited for too long for v0.10... sorry about that.

@janandjill
Copy link

I don't know what he laid down but I'm afraid of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants