Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.0 breaks with node? #261

Closed
Trott opened this issue Nov 8, 2019 · 15 comments
Closed

v1.2.0 breaks with node? #261

Trott opened this issue Nov 8, 2019 · 15 comments

Comments

@Trott
Copy link

Trott commented Nov 8, 2019

Looks like 1.2.0 was perhaps published without running nodefy? Am I wrong? It seems like 1.2.0 breaks esformatter and other modules?

@greengumby
Copy link

Seems like the latest release has broken bower?

nternal/modules/cjs/loader.js:583
throw err;
^

Error: Cannot find module 'mout/lang'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
at Function.Module._load (internal/modules/cjs/loader.js:507:25)
at Module.require (internal/modules/cjs/loader.js:637:17)
at require (internal/modules/cjs/helpers.js:20:18)

@Trott
Copy link
Author

Trott commented Nov 8, 2019

Quickest fix for end users is probably to uninstall mout@1.2.0 and install mout@1.1.0. However another fix is ( cd node_modules/mout && npx nodefy -o . 'src/**.js' ). That will run the step that I believe was missed before publishing 1.2.0. Best of course would be for a maintainer to run nodefy and publish 1.2.1 promptly.

@hzyhbk
Copy link

hzyhbk commented Nov 8, 2019

I found the same problem, because the 1.2.0 package was released without compiling.

@sumanthio
Copy link

sumanthio commented Nov 8, 2019

How do we solve this if the error is from mout in a circular dependancy? wiredep, bower-config so many packages use mout 😱

@Trott
Copy link
Author

Trott commented Nov 8, 2019

/ping @roboshoes

@JoseLawrence
Copy link

JoseLawrence commented Nov 8, 2019

Same issue here with v1.2.0, please!

Error: Cannot find module 'mout/lang'

@Casana
Copy link

Casana commented Nov 8, 2019

We are facing same issue with v1.2.0,so we are downgrading to v1.1.0 which works fine.

@roboshoes
Copy link
Member

Sorry everybody. Deployment issue. Use 1.1.0 until I push a fix today.

@roboshoes
Copy link
Member

1.2.1 was pushed. Preliminary tests show that it deployed correctly. Please feel free to upgrade to this version. I will close this issue after a bit of further testing and improving the deployment process.

@sharif-elshobkshy
Copy link

Have several sites broken due to this issue.

Ohh @roboshoes you little devil

@roboshoes
Copy link
Member

😈

@sharif-elshobkshy is 1.2.1 working for you though?

@alejo-moreno
Copy link

Might be a good time to remember this https://twitter.com/cassidoo/status/1154809678607446016
Anyway, everything is good now 👍

@sharif-elshobkshy
Copy link

sharif-elshobkshy commented Nov 8, 2019

@roboshoes Yes. Seems to be working fine now.

Have a good weekend.

PD: Please don't deploy anything during the weekend :p

@roboshoes
Copy link
Member

Haha, Fair enough!

@Trott
Copy link
Author

Trott commented Nov 8, 2019

This seems fixed. I'm going to close this, but if you think that's the wrong move, feel free to re-open.

@Trott Trott closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants