Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Make editor config key fallback to EDITOR env var on Linux. #274

Closed
THEGOLDENPRO opened this issue Mar 29, 2024 · 1 comment
Closed

[FEATURE] Make editor config key fallback to EDITOR env var on Linux. #274

THEGOLDENPRO opened this issue Mar 29, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@THEGOLDENPRO
Copy link
Member

THEGOLDENPRO commented Mar 29, 2024 •
edited
Loading

At the moment the default value for the editor in mov-cli is nano on Linux but some may not use nano or have it installed so it's good practice to fallback to the editor set in the user's EDITOR environment variable if available. If this isn't available fallback to the usual nano editor.

This change should be done within the editor property method in the config class.
@THEGOLDENPRO THEGOLDENPRO added enhancement New feature or request good first issue Good for newcomers labels Mar 29, 2024
@r3tr0ananas
Copy link
Member

Added with this commit: 3cd9b9c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@THEGOLDENPRO @r3tr0ananas