Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS 2 Branch #133

Closed
peterdavidfagan opened this issue Apr 21, 2023 · 4 comments
Closed

ROS 2 Branch #133

peterdavidfagan opened this issue Apr 21, 2023 · 4 comments

Comments

@peterdavidfagan
Copy link
Member

peterdavidfagan commented Apr 21, 2023

Hi @rhaschke,

Would a pull request for ROS 2 configuration files be welcomed?

I also wished to ask, how are you deciding on what links to enable collisions for? I have been using MSA to generate a self-collision matrix, despite this I have encountered some collisions while planning. I suspect this is due to the coarse collision geometries specified in the urdf of my robot (inherited from the default description files provided by Franka Emika).

@rhaschke
Copy link
Contributor

Would a pull request for ROS 2 configuration files be welcomed?

Sure. I have created a rolling-devel branch.

How are you deciding on what links to enable collisions for?

The Panda has a very specific URDF with its coarse collision geometries. This is not handled nicely by MSA's automated collision checking (essentially the coarse models always collide). Please inherit from the noetic-devel configuration and only apply required changes for ROS2.

@peterdavidfagan
Copy link
Member Author

peterdavidfagan commented Apr 21, 2023

Sure. I have created a rolling-devel branch.

Thanks @rhaschke.

Please inherit from the noetic-devel configuration and only apply required changes for ROS2.

Will do.

@130s 130s mentioned this issue Jun 7, 2023
4 tasks
@130s
Copy link

130s commented Jun 7, 2023

I've started in #136
@peterdavidfagan If you have work-in-progress that you don't mind sharing, I'd like to see.

@130s
Copy link

130s commented Jun 7, 2023

I've started in #136

#136 is ready for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants