Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libs/movex] Fix linting Errors in File io-events.ts #165

Closed
GabrielCTroia opened this issue Oct 20, 2023 · 3 comments · Fixed by #182
Closed

[libs/movex] Fix linting Errors in File io-events.ts #165

GabrielCTroia opened this issue Oct 20, 2023 · 3 comments · Fixed by #182
Assignees
Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest 2023

Comments

@GabrielCTroia
Copy link
Contributor

Where

libs/movex/src/lib/io-connection/io-events.ts

What

When you run npx nx lint movex --quiet you get some errors as below:

Screenshot 2023-10-20 at 1 18 32 PM

Why is it important

Because in the close future, the linting command will be part of the Github Actions

Definition of done

  • running npx nx lint movex --quiet will not return any more errors for this file
  • tsc passes npx nx tsc movex
  • all tests pass yarn test
  • no unnecessary code is introduced
@seog-jun
Copy link
Contributor

I'd like to look into it, and could you label hacktoberfest on it?

@SeptAlfauzan
Copy link

Could you please assign this to me

@GabrielCTroia GabrielCTroia added good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest 2023 labels Oct 21, 2023
@GabrielCTroia
Copy link
Contributor Author

Hey @SeptAlfauzan sorry for the late reply – I'm assigning this to @seog-jun as they were first but I just assigned #164 to you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest 2023
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants