Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libs/movex] Fix linting in file: ClientMasterOrchestration/ClientMaster.spec.ts #179

Closed
GabrielCTroia opened this issue Oct 24, 2023 · 5 comments · Fixed by #191
Closed
Assignees
Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest 2023

Comments

@GabrielCTroia
Copy link
Contributor

Where

libs/movex/src/specs/ClientMasterOrchestration/ClientMaster.spec.ts

What

When you run npx nx lint movex --quiet you get some errors as below:

Screenshot 2023-10-24 at 5 34 49 PM

Replace the culprit line with an import such as

import * as consoleGroup from 'console-group';
consoleGroup.install();

Why is it important

Because in the close future, the linting command will be part of the Github Actions

Definition of done

  • running npx nx lint movex --quiet will not return any more errors for this file
  • tsc passes npx nx tsc movex
  • all tests pass yarn test
  • no unnecessary code is introduced
@GabrielCTroia GabrielCTroia added good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest 2023 labels Oct 24, 2023
@supunvindula
Copy link

Hi there! I'm interested in working on this issue. Could you please assign it to me? I believe I can make a valuable contribution to this task.

Looking forward to your response. Thanks!

@GabrielCTroia
Copy link
Contributor Author

Thank you @supunvindula! I just assigned it to you 🙌

@seog-jun
Copy link
Contributor

@GabrielCTroia If no one is working, please assign it to me. I'll wrap up this issue.

@GabrielCTroia
Copy link
Contributor Author

thank you @seog-jun

@seog-jun
Copy link
Contributor

@GabrielCTroia Can you review the PR? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest 2023
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants